Delete: Self-Destruct #2046

pfefferle · 2025-08-04T08:52:44Z

Fixes #2099.

This PR implements a self-destruct feature for ActivityPub that allows users to remove their blog from the Fediverse by sending Delete activities to all followers. The implementation includes a CLI command, completion tracking, and admin notifications.

Proposed changes:

Implements the wp activitypub self_destruct CLI command with confirmation prompts and progress tracking
Adds completion detection logic that monitors for pending Delete activities and notifies when the process finishes
Provides admin notice functionality to inform users when the self-destruct process is complete

Other information:

Have you written new tests for your changes, if applicable?

Testing instructions:

Run wp activitypub self_destruct in the CLI
Check the Outbox for Delete Activities

Changelog entry

Automatically create a changelog entry from the details below.

Changelog Entry Details

Significance

Patch
Minor
Major

Type

Added - for new features
Changed - for changes in existing functionality
Deprecated - for soon-to-be removed features
Removed - for now removed features
Fixed - for any bug fixes
Security - in case of vulnerabilities

Message

Adds a self-destruct feature to remove a blog from the Fediverse by sending Delete activities to followers.

Improves the self_destruct method to schedule deletion for all users with the 'activitypub' capability, logs each scheduled user, and updates messaging for clarity. Adds an option to mark the deletion process and instructs users to keep the plugin active until completion.

Enhanced the self_destruct command to provide clearer warnings, detailed process steps, and progress feedback when deleting a blog from the Fediverse. Added checks for user existence, improved error handling, and clarified next steps for users after scheduling deletions.

Implements a mechanism to check when all Delete activities for ActivityPub self-destruct are processed, removes the self-destruct flag, and displays an admin notice upon completion. Enhances user feedback and ensures proper cleanup after self-destruct operations.

Changed the action hook from 'activitypub_self_destruct_processing_complete' to 'activitypub_outbox_processing_complete' and updated the method signature for check_self_destruct_completion to accept only inboxes and JSON. Adjusted post type, status, and meta key in the pending deletes query for consistency with Outbox implementation.

Co-authored-by: Copilot <[email protected]>

Replaces direct parameters with an Activity object when adding a 'Delete' activity to the outbox. This change improves consistency and leverages the Activity class for better structure.

includes/wp-admin/class-admin.php

includes/class-cli.php

The self_destruct WP-CLI command for ActivityPub is now refactored for modularity and clarity, with improved documentation, confirmation handling, and status checking. The process is split into smaller private methods, and a new --status flag allows users to check progress. The self-destruct completion logic and related hook are removed from Scheduler, and status tracking is now handled directly in the CLI command.

Standardized inline comments by adding missing periods for consistency and improved readability in class-cli.php.

Co-authored-by: Copilot <[email protected]>

obenland · 2025-08-26T18:49:24Z

%  wp activitypub self_destruct --status

🔍 Self-Destruct Status Check

⏳ Status: IN PROGRESS
The self-destruct process is currently running.

📊 Progress: 1 Delete Activities still pending

💡 Note: The process may take several minutes to complete.

AI sure loves their emoji

pfefferle · 2025-08-26T18:51:28Z

not good?

obenland · 2025-08-26T18:57:30Z

I don't care too much but others might. Having one on every line arguably makes their effects moot.

includes/class-cli.php

Co-authored-by: Konstantin Obenland <[email protected]>

Adjusted the alignment of 'key' and 'value' in the meta_query array for better code readability and consistency.

Emojis were removed from the progress and note messages in the self-destruct process output to improve compatibility and readability in CLI environments.

Consolidated and reformatted the message shown when the self-destruct process has not started, making the command to run more visible and easier to follow.

Replaces the import of Followers with Outbox in the class-cli.php file to ensure correct class usage.

Copilot

Pull Request Overview

This PR implements a self-destruct feature for ActivityPub that allows users to completely remove their blog from the Fediverse by sending Delete activities to all followers. This is an irreversible operation designed to provide a clean exit mechanism from ActivityPub networks.

Adds a comprehensive CLI command wp activitypub self_destruct with confirmation prompts, status checking, and progress tracking
Implements completion detection that monitors pending Delete activities and provides admin notifications when the process finishes
Provides user-friendly feedback and safety measures including warnings, confirmation prompts, and status monitoring

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
includes/class-cli.php	Implements the main self-destruct CLI command with user confirmation, progress tracking, and status checking functionality
includes/wp-admin/class-admin.php	Adds admin notice display for self-destruct completion notifications
.github/changelog/2046-from-description	Adds changelog entry for the new self-destruct feature

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

includes/class-cli.php

pfefferle added 2 commits July 30, 2025 12:11

Init

c3a65ff

Merge branch 'trunk' into add/self-destruct

6aedee8

github-actions bot added [Feature] CLI [Status] In Progress labels Aug 4, 2025

pfefferle added 2 commits August 6, 2025 12:14

pfefferle added this to the User Delete milestone Aug 6, 2025

pfefferle added 2 commits August 6, 2025 13:09

Merge branch 'trunk' into add/self-destruct

6baccc0

github-actions bot added the [Feature] WP Admin label Aug 6, 2025

pfefferle marked this pull request as ready for review August 6, 2025 11:12

Copilot AI review requested due to automatic review settings August 6, 2025 11:12

This comment was marked as outdated.

Sign in to view

pfefferle and others added 2 commits August 6, 2025 13:15

Update includes/class-cli.php

e60da0b

Co-authored-by: Copilot <[email protected]>

pfefferle self-assigned this Aug 6, 2025

Add changelog

a44cdda

pfefferle requested review from obenland and Copilot August 6, 2025 11:25

This comment was marked as outdated.

Sign in to view

pfefferle added 2 commits August 6, 2025 13:55

Refactor outbox deletion to use Activity object

68d3f74

Replaces direct parameters with an Activity object when adding a 'Delete' activity to the outbox. This change improves consistency and leverages the Activity class for better structure.

Merge branch 'trunk' into add/self-destruct

aebbe8a

obenland reviewed Aug 19, 2025

View reviewed changes

includes/wp-admin/class-admin.php Show resolved Hide resolved

includes/class-cli.php Outdated Show resolved Hide resolved

pfefferle added 3 commits August 26, 2025 17:20

Merge branch 'trunk' into add/self-destruct

f1f03b6

Add missing periods to inline comments

1d6c851

Standardized inline comments by adding missing periods for consistency and improved readability in class-cli.php.

pfefferle requested review from obenland and Copilot August 26, 2025 18:00

This comment was marked as outdated.

Sign in to view

Update includes/class-cli.php

7c963a2

Co-authored-by: Copilot <[email protected]>

obenland reviewed Aug 26, 2025

View reviewed changes

includes/class-cli.php Outdated Show resolved Hide resolved

obenland reviewed Aug 26, 2025

View reviewed changes

includes/class-cli.php Outdated Show resolved Hide resolved

pfefferle and others added 4 commits August 26, 2025 21:12

Update includes/class-cli.php

fce5300

Co-authored-by: Konstantin Obenland <[email protected]>

Update includes/class-cli.php

36bb6ab

Co-authored-by: Konstantin Obenland <[email protected]>

Fix array alignment in meta_query for CLI command

99e7644

Adjusted the alignment of 'key' and 'value' in the meta_query array for better code readability and consistency.

Remove emojis from CLI progress messages

46c4be0

Emojis were removed from the progress and note messages in the self-destruct process output to improve compatibility and readability in CLI environments.

pfefferle requested a review from Copilot August 26, 2025 19:21

This comment was marked as outdated.

Sign in to view

pfefferle added 3 commits August 26, 2025 21:23

Improve CLI self-destruct process instructions

a5a6160

Consolidated and reformatted the message shown when the self-destruct process has not started, making the command to run more visible and easier to follow.

Merge branch 'trunk' into add/self-destruct

4047836

Fix incorrect import in class-cli.php

43e95d2

Replaces the import of Followers with Outbox in the class-cli.php file to ensure correct class usage.

pfefferle requested review from obenland and Copilot August 27, 2025 06:35

Copilot AI reviewed Aug 27, 2025

View reviewed changes

includes/class-cli.php Show resolved Hide resolved

includes/class-cli.php Show resolved Hide resolved

obenland mentioned this pull request Aug 27, 2025

Separate Instance Actor and Blog Profile for Delete Actor Implementation #2099

Closed

obenland approved these changes Aug 27, 2025

View reviewed changes

pfefferle merged commit 6984d23 into trunk Aug 27, 2025
15 checks passed

pfefferle deleted the add/self-destruct branch August 27, 2025 14:26

github-actions bot removed the [Status] In Progress label Aug 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Delete: Self-Destruct #2046

Delete: Self-Destruct #2046

Uh oh!

pfefferle commented Aug 4, 2025 •

edited by obenland

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

obenland commented Aug 26, 2025

Uh oh!

pfefferle commented Aug 26, 2025

Uh oh!

obenland commented Aug 26, 2025

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Delete: Self-Destruct #2046

Delete: Self-Destruct #2046

Uh oh!

Conversation

pfefferle commented Aug 4, 2025 • edited by obenland Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Other information:

Testing instructions:

Changelog entry

Significance

Type

Message

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

obenland commented Aug 26, 2025

Uh oh!

pfefferle commented Aug 26, 2025

Uh oh!

obenland commented Aug 26, 2025

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pfefferle commented Aug 4, 2025 •

edited by obenland

Loading